Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not exclude gz-common from focal ci_configs #1094

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Dec 13, 2023

ign-common4 (Fortress) is configured to run on focal, but we were excluding the abichecker from the focal ci_configs.

https://build.osrfoundation.org/job/gz_common-abichecker-any_to_any-ubuntu-jammy-amd64/ only triggers on gz-common5.

ign-common4 (Fortress) is configured to run on `focal`, but we were
excluding the abichecker from the `focal` ci_configs.

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from j-rivero as a code owner December 13, 2023 19:41
@azeey azeey requested review from j-rivero and removed request for j-rivero December 13, 2023 19:41
@j-rivero
Copy link
Contributor

In fact, since we moved Citadel from Bionic to Focal we also need to remove the other exclusions:

        - gz-math
        - gz-plugin
        - gz-utils

This is going to have the side effect of making the branches shared by Garden (ci_config is focal) and Harmonic(ci_config is jammy) to duplicate the abichecker jobs. I'll open an issue and think the best way of dealing with this.

@azeey
Copy link
Contributor Author

azeey commented Dec 14, 2023

In fact, since we moved Citadel from Bionic to Focal we also need to remove the other exclusions:

        - gz-math
        - gz-plugin
        - gz-utils

This is going to have the side effect of making the branches shared by Garden (ci_config is focal) and Harmonic(ci_config is jammy) to duplicate the abichecker jobs. I'll open an issue and think the best way of dealing with this.

Thanks for the fix!

@azeey
Copy link
Contributor Author

azeey commented Dec 14, 2023

Can we merge this before we find a solution to #1095 to unblock gazebosim/gz-common#559?

@j-rivero
Copy link
Contributor

Can we merge this before we find a solution to #1095 to unblock gazebosim/gz-common#559?

sure!

@j-rivero j-rivero merged commit acfc1e1 into master Dec 14, 2023
1 check passed
@j-rivero j-rivero deleted the azeey/common-abi-checker branch December 14, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants