Change all PR ci jobs (-ci-pr_any-) to use the yaml configuration #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
This reverts commit b097771.
Signed-off-by: Jose Luis Rivero <[email protected]>
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI moves all CI done in our repositories to use the yaml documentation. After adding all distribution metadata to the yaml file in #1017, we are in the position of moving all the
-ci-pr_any-generated jobs to use the yaml configuration.Until now the
-ci-pr_any-ubuntu-autojobs register all supported branches and dispatch the CI work. The new setup creates jobs based on the ubuntu distribution, so now the names are-ci-pr_any-ubuntu-${distro}. Each job register the supported branches (i.e:-ci-pr_any-ubuntu-jammysupports Garden and Harmonic branches).Some details:
-ci-pr_any-ubuntu-autojobs can not be renamed to the new-ci-pr_any-ubuntu-${distro}. This PR set a transition step of returning alwaystruefrom the old jobs before removing the completely. This should help people not to focus on the existing failing ones. After some weeks, the jobs will be removed. See 7473a18mainbranches jobs using the__upcoming__distribution defined in the yaml file.-ci-${branch}-from the yaml file. This is for a new PR to reduce the scope of the testing. fbe24f3Testing done:
I have been using the XML diff to be sure that the configuration match the expectations from both, CI system and local checks. Here is what I have expected and results:
A) All the
ci-pr_any-ubuntu-autojobs should change to be just fake jobs that returns only true.A1) Testing with the log file from the CI system in release-tools to see if all auto files differ:
A2) Check a random job to see the returning true and a minimal configuration file:
A3) Test in Jenkins that new fake jobs works returning just true:
https://build.osrfoundation.org/job/_test_migration_ci_pr_any/2/
B) Existing
ci-pr_any-ubuntu-jammyjobs created for Harmonic and in use would need to support the branches in upcoming:B1) XML log diff should report only jammy jobs if we don't include the -auto jobs mentioned in A).
B2) Changes in the content of these files should show the
mainbranch be added:B3) Check all new white listed branches to see if they have sense. We expect main and latest released branches:
C) New jobs added in this PR:
C1) There should be focal testing (for Fortress and Garden)
C2) Check that branches are the expected. All focal jobs should have two since Garden bumped everything from Fortress:
C3) Bionic testing (for Citadel) Still uses the ign name