Big clean up of release.py script #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
20 tasks
azeey
requested changes
Sep 26, 2023
release.py
Outdated
| @@ -493,7 +495,7 @@ def generate_upload_tarball(args): | |||
| # If we're releasing under a different name, then rename the tarball (the | |||
| # package itself doesn't know anything about this). | |||
| if args.package != args.package_alias: | |||
| tarball_fname = '%s-%s.tar.bz2'%(args.package_alias, args.version) | |||
| tarball_fname = ' %s-%s.tar.bz2' % (args.package_alias, args.version) | |||
There was a problem hiding this comment.
This failed for me with
!! Can not find a tarball at: /tmp/tmp8ttiifnf/build/ gz-cmake-3.4.1.tar.bz2 or at /tmp/tmp8ttiifnf/build/ gz_cmake-3.4.1.tar.bz2
I think the issue is there are a number of places where an extra space is added inside string formats that didn't have it before. Search for ' %s
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A big first clean up in the ancient
release.pyscript. Some major changes that I believe probably noone was using nowadays:--no-ignition-autooption--upstreamoptionFormatting/Linting fixes:
The changes are easier to navigate commit-by-commit, the commit description should be good to understand each of them.