reset the search engine on the about:home page #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notice that I had the wrong order for the alert parameters. Took the opportunity to do some testing with prefs locked via mozilla.cfg that prevented finishing properly. Added some DEBUG code for testing. I think that it is working now.
|
|
||
| if (originalDefaultEngine) { |
There was a problem hiding this comment.
You shouldn't need to add this check - after having reset the defaultenginename pref, originalDefaultEngine is garanteed to be present and represent the the build's default engine, unless its default value is corrupt due to e.g. an addon, but I don't think we should try to handle that case.
New proposal that addresses most changes.
Kept "if (originalDefaultEngine) {}" and moved the about:home code under it.
Improved the DEBUG info under resetPref().
browser.startup.homepage and browser.search.defaultenginename are complex values and thus are reset to chrome://browser-region/locale/region.properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the code to bootstrap.js as proposed in the SUMO contributors forum
https://support.mozilla.org/forums/contributors/708557#post-48144
I have added a try and catch with an alert just in case because they have changed getCodebasePrincipal to getNoAppCodebasePrincipal in Firefox 17