fix: Show correct simulation name in reports (local runs) #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Local run reports currently show the name of the Java adapter class instead of the simulation name. Modifications: Override simulation name with the correct name. Result: Reports show the expected simulation name (derived from the simulation file name).
guilgaly
commented
Nov 19, 2024
| @@ -17,7 +17,7 @@ val compilerRelease = 21 | |||
| val graalvmJdkVersion = "23.0.0" | |||
| val graalvmJsVersion = "24.1.1" | |||
| val coursierVersion = "2.1.12" | |||
| val gatlingVersion = "3.13.1" | |||
| val gatlingVersion = "3.13.2-SNAPSHOT" | |||
notdryft
approved these changes
Nov 19, 2024
slandelle
approved these changes
Nov 19, 2024
|
Closed as not necessary, we ended up just using the existing system property. Upgrading to the new Gatling version will be enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft - depends on gatling/gatling-private#1033
Motivation:
Local run reports currently show the name of the Java adapter class instead of the simulation name.
Modifications:
Override simulation name with the correct name.
Result:
Reports show the expected simulation name (derived from the simulation file name).