merge Engine with Server #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mostafa
reviewed
Dec 22, 2023
There was a problem hiding this comment.
Hey @snowAvocado,
Thanks for your contribution! 🙏 I have two comments:
- Please fix linter errors (and ignore unimportant ones).
- You can merge the stop with shutdown and unexport the stop method, effectively removing it from the interface.
mostafa
previously approved these changes
Dec 23, 2023
|
@snowAvocado Please sign your commits. |
snowAvocado
force-pushed
the
merge-engine-to-server
branch
from
8002e43 to
eb44f41
Compare
snowAvocado
force-pushed
the
merge-engine-to-server
branch
from
3f81aa1 to
214afaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s)
Description
Related PRs
Development Checklist
Legal Checklist