Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds a check that only single ferry can happen on a deposit request gasp-1652 #858

Merged
merged 1 commit into from
Dec 5, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pallets/rolldown/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -525,6 +525,8 @@ pub mod pallet {
UninitializedChainId,
// Asset can be withdrawn only to sender's address
NontransferableToken,
// the deposit was already ferried
AlreadyFerried,
}

#[cfg(feature = "runtime-benchmarks")]
Expand Down Expand Up @@ -1843,6 +1845,11 @@ impl<T: Config> Pallet<T> {
return Err(Error::<T>::AlreadyExecuted);
}

ensure!(
!FerriedDeposits::<T>::contains_key((chain, deposit_hash)),
Error::<T>::AlreadyFerried
);

let amount = deposit
.amount
.checked_sub(deposit.ferryTip)
Expand Down
Loading