-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GASP-1625 Feature/locked tokens #841
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanderian
commented
Nov 26, 2024
rollup/runtime/src/runtime_config.rs
Outdated
Comment on lines
51
to
55
#[cfg(any(feature = "unlocked", feature = "runtime-benchmarks"))] | ||
pub type NontransferableTokens = Nothing; | ||
#[cfg(not(feature = "unlocked"))] | ||
pub type NontransferableTokens = Equals<ConstU32<RX_TOKEN_ID>>; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all allowed for eg testnet
otherwise just native token '0'
goncer
approved these changes
Nov 26, 2024
An error occurred while trying to automatically change base from
feature/stable-pool-mgx-1307
to
eth-rollup-develop
November 26, 2024 22:41
An error occurred while trying to automatically change base from
feature/stable-pool-mgx-1307
to
eth-rollup-develop
November 26, 2024 22:41
An error occurred while trying to automatically change base from
feature/stable-pool-mgx-1307
to
eth-rollup-develop
November 26, 2024 22:41
An error occurred while trying to automatically change base from
feature/stable-pool-mgx-1307
to
eth-rollup-develop
November 26, 2024 22:41
An error occurred while trying to automatically change base from
feature/stable-pool-mgx-1307
to
eth-rollup-develop
November 27, 2024 08:58
vanderian
force-pushed
the
feature/locked-tokens
branch
from
November 28, 2024 14:13
70d49a9
to
6520855
Compare
vanderian
changed the base branch from
feature/stable-pool-mgx-1307
to
eth-rollup-develop
November 28, 2024 14:14
goncer
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds checks for non transferable tokens
--features=unlocked
removes such restrictionsruntime cofing defines the native currency -
0
as non transferable tokentokens all transfer calls, set_balance, mint extrinsics are checked
market create, mint, burn are checked
market swaps are allowed
foundation members have veto over:
market create_pool & burn