Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup new matrix for run with chops - dynamic matrix #636

Closed
wants to merge 23 commits into from

Merge branch 'develop' into feature/runWithchops

0c2aac7
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Closed

Setup new matrix for run with chops - dynamic matrix #636

Merge branch 'develop' into feature/runWithchops
0c2aac7
Select commit
Loading
Failed to load commit list.
GitHub Actions / E2E report yarn test-parallel-skipped-chops --max-workers=10 failed Nov 14, 2023 in 1s

E2E report yarn test-parallel-skipped-chops --max-workers=10 ❌

Tests failed

❌ e2eTests/reports/junit.xml-e0cbcc10-830d-11ee-a065-6b396dae308f.xml

62 tests were completed in 1260s with 54 passed, 1 failed and 7 skipped.

Test suite Passed Failed Skipped Time
test/parallel/feeLock.API.feePayment.parallel.test.ts 5✅ 946s
test/parallel/feeLock.API.rpcValueThresholds.test.ts 1✅ 1❌ 239s
test/parallel/feeLock.API.swapValueThresholds.test.ts 3✅ 599s
test/parallel/feeLock.API.unlocking.test.ts 5✅ 1258s
test/parallel/tips.swapOperations.test.ts 6✅ 83s
test/parallel/xyk-pallet.API.fees.tripleTokens.test.ts 7✅ 1⚪ 959s
test/parallel/xyk-pallet.API.overflow.test.ts 4✅ 6⚪ 323s
test/parallel/xyk-pallet.API.testMGArequired.test.ts 4✅ 598s
test/parallel/xyk-rpc.errors.test.ts 19✅ 83s

✅ test/parallel/feeLock.API.feePayment.parallel.test.ts

✅ gasless- GIVEN a feeLock configured WHEN a swap happens THEN fees are not charged but locked instead
✅ gasless- GIVEN a correct config for gasless swaps WHEN the user runs unlock-fee THEN fees are not charged for token unlockFee
✅ gasless- High-value swaps are rejected from the txn pool if they would fail before the percentage fee is charged
✅ gasless- For low-value swaps, token reservation status and pallet storage are altered in accordance with the timeout mechanism
✅ gasless- High-value swaps when successful are not charged txn fee or token locked, but the percentage fee is charged

❌ test/parallel/feeLock.API.rpcValueThresholds.test.ts

❌ gasless- isFree depends on the token and the sell valuation
	Error: expect(received).toBeFalsy()
✅ gasless- isFree works same as multiswap of two

✅ test/parallel/feeLock.API.swapValueThresholds.test.ts

✅ gasless- Given a feeLock correctly configured WHEN the user swaps two tokens defined in the thresholds AND swapValue > threshold THEN the extrinsic is correctly submitted AND No locks AND no fees
✅ gasless- Given a feeLock correctly configured WHEN the user swaps two tokens defined in the thresholds AND the user has enough MGAs AND swapValue < threshold THEN some MGAs will be locked
✅ gasless- Given a feeLock correctly configured WHEN the user swaps two tokens that are not defined in the thresholds AND the user has not enough MGAs AND swapValue > threshold THEN the extrinsic can not be submited

✅ test/parallel/feeLock.API.unlocking.test.ts

✅ gasless- GIVEN some locked tokens and no more free MGX WHEN another tx is submitted AND lock period did not finished THEN the operation can not be submitted
✅ gasless- GIVEN some locked tokens and no more free MGX WHEN another tx is submitted AND lock period finished THEN the operation can be submitted ( unlock before locking )
✅ gasless- GIVEN some locked tokens WHEN querying accountFeeLockData THEN the amount matches with locked tokens AND lastFeeLockBlock matches with the block when tokens were locked
✅ gasless- GIVEN some locked tokens and lastFeeLockBlock is lower than current block WHEN release feeLock is requested THEN the tokens are unlocked
✅ gasless- GIVEN a lock WHEN the period is N THEN the tokens can not be unlocked before that period

✅ test/parallel/tips.swapOperations.test.ts

Tips - Tips are not allowed for swaps
  ✅ multiswapSellAsset tips operations are forbidden
  ✅ multiswapBuyAsset tips operations are forbidden
  ✅ sellAsset tips operations are forbidden
  ✅ buyAsset tips operations are forbidden
  ✅ transfer tips operations are allowed
  ✅ mint tips operations are allowed

✅ test/parallel/xyk-pallet.API.fees.tripleTokens.test.ts

✅ xyk-pallet - Check required fee - User with MGX only
✅ xyk-pallet - Check required fee - User with KSM only
✅ xyk-pallet - Check required fee - User with TUR only
✅ xyk-pallet - Check required fee - User with some MGA, very few KSM and very few TUR
✅ xyk-pallet - Check required fee - User with very few MGA, some KSM and very few TUR
✅ xyk-pallet - Check required fee - User with very few MGA, very few KSM and some TUR
✅ xyk-pallet - Check required fee - User with very few  MGA, very few KSM and very few TUR, operation fails
⚪ BUG under discussion:xyk-pallet - when minting all MGX should pay fees with ksm ?- Check required fee - User with very few MGA, some KSM and very few TUR

✅ test/parallel/xyk-pallet.API.overflow.test.ts

xyk-pallet - Check operations are not executed because of overflow in asset token
  ✅ Create pool of [MAX,MAX]: OverFlow [a+b] - liquidityAsset calculation
  ✅ Minting Max+1 tokens operation fails
  ⚪ Transfer [MAX] assets to other user when that user has 1 asset. Max+1 => overflow.
xyk-pallet - Operate with a pool close to overflow
  ✅ Sell [MAX -2] assets to a wallet with Max-1000,1000 => overflow.
  ✅ Buy [100] assets to a wallet with Max-1000,1000 => overflow.
  ⚪ Mint liquidities [1000] assets to a wallet with Max-1000,1000 => overflow.
  ⚪ [BUG] Burn liquidities [MAX -1] assets to a wallet wich is full => overflow. NOT  a bug https://trello.com/c/J3fzuwH5
xyk-pallet - Operate with a user account close to overflow
  ⚪ Sell a few assets to a wallet that is full => overflow. NOT A BUG: https://trello.com/c/J3fzuwH5
  ⚪ Buy a few assets to a wallet that is full  => overflow. NOT A BUG: https://trello.com/c/J3fzuwH5
xyk-pallet - Operate with a highly unbalanced pool [mg - newAsset]
  ⚪ [BUG] Buy a few assets to a wallet linked to MGA  => overflow.

✅ test/parallel/xyk-pallet.API.testMGArequired.test.ts

Wallets unmodified
  ✅ xyk-pallet - User Balance - Creating a pool requires paying fees
  ✅ xyk-pallet - User Balance - mint liquidity requires paying fees
✅ xyk-pallet - User Balance - Selling an asset does not require paying fees
✅ xyk-pallet - User Balance - Buying an asset does not require paying fees

✅ test/parallel/xyk-rpc.errors.test.ts

✅ xyk-rpc - calculate_sell_price validates parameters - Negative params
✅ xyk-rpc - calculate_sell_price validates parameters - Negative params
✅ xyk-rpc - calculate_sell_price validates parameters - Negative params
✅ xyk-rpc - calculate_sell_price validates parameters - Zeroes [inputReserve->1,outputReserve->1,amount->0,expected->0]
✅ xyk-rpc - calculate_sell_price validates parameters - Zeroes [inputReserve->0,outputReserve->0,amount->0,expected->0]
✅ xyk-rpc - calculate_sell_price validates parameters - Zeroes [inputReserve->0,outputReserve->1,amount->1,expected->1]
✅ xyk-rpc - calculate_sell_price validates parameters - Zeroes [inputReserve->0,outputReserve->0,amount->1,expected->0]
✅ xyk-rpc - calculate_buy_price validates parameters - Zeroes [inputReserve->1,outputReserve->1,amount->0,expected->1]
✅ xyk-rpc - calculate_buy_price validates parameters - Zeroes [inputReserve->0,outputReserve->0,amount->0,expected->0]
✅ xyk-rpc - calculate_buy_price validates parameters - Zeroes [inputReserve->0,outputReserve->1,amount->1,expected->0]
✅ xyk-rpc - calculate_buy_price validates parameters - Zeroes [inputReserve->0,outputReserve->0,amount->1,expected->0]
✅ xyk-rpc - calculate_buy_price validates parameters - Zeroes [inputReserve->1,outputReserve->0,amount->0,expected->0]
✅ validate parameters: negative asset ids [soldTokenId->-1,boughtTokenId->0,amount->0,expected->createType(TokenId):: u32: Negative number passed to unsigned type]
✅ validate parameters: negative asset ids [soldTokenId->0,boughtTokenId->-1,amount->0,expected->createType(TokenId):: u32: Negative number passed to unsigned type]
✅ RPC big numbers : negative asset ids [amount->100000000]
✅ RPC big numbers : negative asset ids [amount->100000000000000]
✅ RPC big numbers : negative asset ids [amount->10000000000000000000000]
xyk-rpc - calculate_buy_price_by_id:No pool assotiated with the assets
  ✅ validate parameters [soldTokenId->0,boughtTokenId->1,amount->0,expected->0]
  ✅ validate parameters [soldTokenId->1,boughtTokenId->0,amount->1,expected->0]

Annotations

Check failure on line 0 in e2eTests/reports/junit.xml-e0cbcc10-830d-11ee-a065-6b396dae308f.xml

See this annotation in the file changed.

@github-actions github-actions / E2E report yarn test-parallel-skipped-chops --max-workers=10

test/parallel/feeLock.API.rpcValueThresholds.test.ts ► gasless- isFree depends on the token and the sell valuation

Failed test found in:
  e2eTests/reports/junit.xml-e0cbcc10-830d-11ee-a065-6b396dae308f.xml
Error:
  Error: expect(received).toBeFalsy()
Raw output
Error: expect(received).toBeFalsy()

Received: true
    at /home/runner/_work/mangata-node/mangata-node/e2eTests/test/parallel/feeLock.API.rpcValueThresholds.test.ts:147:5
    at Generator.next (<anonymous>)
    at fulfilled (/home/runner/_work/mangata-node/mangata-node/e2eTests/test/parallel/feeLock.API.rpcValueThresholds.test.ts:4:58)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)