Rc/0.31.0 #614
Merged
Rc/0.31.0 #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'t require newer rustc compiler version (#598)
- New functionality where the pools and assets will never be deleted and instead we will accept empty pools and make our storage history consistent
As agreed this PR introduces number of api breaking changes:
- `XYKRpcResult` is removed
- `RPCAmountsResult` is removed
- `calculate_sell_price` : returns `RpcResult<Balance>` instead of
`RpcResult<XYKRpcResult>`
- `calculate_buy_price` : returns `RpcResult<Balance>` instead of
`RpcResult<XYKRpcResult>`
- `calculate_sell_price_id` : returns `RpcResult<Balance>` instead of
`RpcResult<XYKRpcResult>`
- `calculate_buy_price_id` : returns `RpcResult<Balance>` instead of
`RpcResult<XYKRpcResult>`
- `get_burn_amount` : returns `RpcResult<(Balance,Balance)>` instead of
`RpcResult<RPCAmountsResult>`
- `get_max_instant_burn_amount` : returns `RpcResult<Balance>` instead
of `RpcResult<XYKRpcResult>`
- `get_max_instant_unreserve_amount` : returns `RpcResult<Balance>`
instead of `RpcResult<XYKRpcResult>`
- `calculate_rewards_amount` : returns `RpcResult<Balance>` instead of
`RpcResult<XYKRpcResult>`
- `calculate_Balanced_sell_amount` :
* returns `RpcResult<Balance>` instead of `RpcResult<XYKRpcResul>`
* `total_amount` parameter type change from `Balance` to `NumberOrHex`
* `reserve_amount` parameter type change from `Balance` to `NumberOrHex`
- `is_buy_asset_lock_free`: `input_amount` type changed from `Balance`
to `NumberOrHex`
- `is_sell_asset_lock_free`: `input_amount` type changed from `Balance`
to `NumberOrHex`
now sdk validates node version. bumped to 18.16.1
Add yarn test-sdk
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #614 +/- ##
=======================================
Coverage ? 50.06%
=======================================
Files ? 29
Lines ? 4067
Branches ? 0
=======================================
Hits ? 2036
Misses ? 2031
Partials ? 0 ☔ View full report in Codecov by Sentry. |
goncer
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.