Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MGX-632] 3rdparty rewards #593

Closed
wants to merge 90 commits into from
Closed

Conversation

mateuszaaa
Copy link
Member

@mateuszaaa mateuszaaa commented Sep 7, 2023

This PR introduces 3rdparty rewards feature. Please see recent docs

Deprecated RPC calls:

  • rpc XYK::claim_rewards_all -> ProofOfStake::claim_native_rewards

Deprecated Extirnsics:

  • ProofOfStake::activate_liquidity -> ProofOfStake::activate_liquidity_for_native_rewards
  • ProofOfStake::deactivate_liquidity -> ProofOfStake::deactivate_liquidity_for_native_rewards
  • ProofOfStake::claim_rewards_all -> ProofOfStake::claim_native_rewards

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Attention: 176 lines in your changes are missing coverage. Please review.

Comparison is base (504ec52) 50.06% compared to head (810e34f) 52.69%.
Report is 1 commits behind head on develop.

❗ Current head 810e34f differs from pull request most recent head 5f47e65. Consider uploading reports for the commit 5f47e65 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #593      +/-   ##
===========================================
+ Coverage    50.06%   52.69%   +2.63%     
===========================================
  Files           29       34       +5     
  Lines         4067     4644     +577     
===========================================
+ Hits          2036     2447     +411     
- Misses        2031     2197     +166     
Files Coverage Δ
node/src/service.rs 0.00% <ø> (ø)
pallets/proof-of-stake/src/tests.rs 96.66% <ø> (ø)
runtime/common/src/lib.rs 0.00% <ø> (ø)
runtime/mangata-kusama/src/lib.rs 0.00% <ø> (ø)
runtime/mangata-rococo/src/lib.rs 0.00% <ø> (ø)
node/src/rpc.rs 0.00% <0.00%> (ø)
pallets/xyk/src/lib.rs 61.76% <71.42%> (-0.16%) ⬇️
pallets/proof-of-stake/src/benchmarking.rs 0.00% <0.00%> (ø)
pallets/proof-of-stake/src/utils.rs 87.50% <87.50%> (ø)
.../proof-of-stake/src/schedule_rewards_calculator.rs 87.34% <87.34%> (ø)
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mateuszaaa mateuszaaa force-pushed the feature/3rdparty-rewards branch from d3969b2 to 76bb3d5 Compare September 13, 2023 09:54
@mateuszaaa mateuszaaa force-pushed the feature/3rdparty-rewards branch from 76bb3d5 to 6c4bfdf Compare September 14, 2023 10:33
@mateuszaaa mateuszaaa force-pushed the feature/3rdparty-rewards branch from 9dcb52e to 1709ea7 Compare September 15, 2023 10:06
@mateuszaaa mateuszaaa force-pushed the feature/3rdparty-rewards branch 2 times, most recently from 197152c to c4639c2 Compare September 21, 2023 16:13
@mateuszaaa mateuszaaa force-pushed the feature/3rdparty-rewards branch from c4639c2 to 5beb83b Compare September 21, 2023 16:22
@mateuszaaa mateuszaaa force-pushed the feature/3rdparty-rewards branch from 88b3baf to 5047104 Compare September 26, 2023 09:02
@mateuszaaa mateuszaaa force-pushed the feature/3rdparty-rewards branch from 3ca5951 to 810e34f Compare November 2, 2023 21:05
@mateuszaaa
Copy link
Member Author

created new PR for post monorepo alignment #643

@mateuszaaa mateuszaaa closed this Nov 13, 2023
mateuszaaa added a commit that referenced this pull request Nov 27, 2023
This PR introduces 3rdparty rewards feature.

Deprecated RPC calls:

    rpc XYK::claim_rewards_all -> ProofOfStake::claim_native_rewards

Deprecated Extirnsics:

ProofOfStake::activate_liquidity ->
ProofOfStake::activate_liquidity_for_native_rewards
ProofOfStake::deactivate_liquidity ->
ProofOfStake::deactivate_liquidity_for_native_rewards
ProofOfStake::claim_rewards_all -> ProofOfStake::claim_native_rewards
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation full-benchmarks perform full benchmarking and archive results
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant