fixes test, invert min max typo

gasp-xyz · Dec 4, 2024 · 383043e · 383043e
1 parent 35152fa
commit 383043e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/pallets/rolldown/src/lib.rs b/pallets/rolldown/src/lib.rs
@@ -1521,8 +1521,8 @@ impl<T: Config> Pallet<T> {
 			update_hash: update.abi_encode_hash(),
 			update_size: update.pendingDeposits.len() as u128 +
 				update.pendingCancelResolutions.len() as u128,
-			max_id: lowest_id,
-			min_id: last_id,
+			min_id: lowest_id,
+			max_id: last_id,
 		})
 	}
 

diff --git a/pallets/rolldown/src/tests.rs b/pallets/rolldown/src/tests.rs
@@ -1028,7 +1028,10 @@ fn reject_update_with_invalid_too_high_request_id() {
 
 #[test]
 #[serial]
-fn reject_update_without_new_updates() {
+// changed to accept
+// seq gets the rights BEFORE LastProcessedRequestOnL2 is updated
+// a single request would be duplicated, extrinsic fail and break seq 
+fn accept_update_without_new_updates() {
 	ExtBuilder::new().execute_with_default_mocks(|| {
 		forward_to_block::<Test>(10);
 
@@ -1044,9 +1047,8 @@ fn reject_update_without_new_updates() {
 		forward_to_block::<Test>(16);
 		assert_eq!(LastProcessedRequestOnL2::<Test>::get(consts::CHAIN), 1u128.into());
 
-		assert_err!(
-			Rolldown::update_l2_from_l1_unsafe(RuntimeOrigin::signed(ALICE), deposit_update),
-			Error::<Test>::WrongRequestId
+		assert_ok!(
+			Rolldown::update_l2_from_l1_unsafe(RuntimeOrigin::signed(ALICE), deposit_update)
 		);
 	});
 }