update #3
Open
update #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @GeneratedValue(strategy = GenerationType.IDENTITY) | ||
| private Long productId; | ||
| @Id | ||
| @GeneratedValue(strategy = GenerationType.IDENTITY) |
There was a problem hiding this comment.
better to use sequence
| } | ||
| @Override | ||
| public int hashCode() { | ||
| return getClass().hashCode(); |
There was a problem hiding this comment.
not a good idea. equals and hashcode should be interconnected. please use the same fields
| @@ -9,26 +9,27 @@ | |||
| import lombok.extern.slf4j.Slf4j; | |||
| import org.springframework.stereotype.Service; | |||
|
|
|||
|
|
|||
| @Service | |||
| @RequiredArgsConstructor | |||
| @Slf4j | |||
| public class ProductFacade implements ProductUniquenessFacade { | |||
There was a problem hiding this comment.
better to make package-private to not allow others to use it
| @@ -8,22 +8,23 @@ | |||
| import lombok.extern.slf4j.Slf4j; | |||
| import org.springframework.stereotype.Service; | |||
|
|
|||
|
|
|||
| @Service | |||
| @RequiredArgsConstructor | |||
| @Slf4j | |||
| public class ProductService implements ProductDomainService { | |||
There was a problem hiding this comment.
better to make package-private
| } | ||
| public MetricsService(MeterRegistry registry) { | ||
| log.info("Registering product countMetric into the Prometheus."); | ||
| Gauge.builder("product_counter", fetchProductCount()) |
There was a problem hiding this comment.
let's use Counter instead
| @@ -7,23 +7,24 @@ | |||
| import java.util.Set; | |||
| import java.util.concurrent.ConcurrentHashMap; | |||
|
|
|||
|
|
|||
| @RequiredArgsConstructor | |||
| @Slf4j | |||
| @Service | |||
| public class ProductCounterService { | |||
| log.info("Checking if the product is unique in the in memory counter {}", productDto.getName()); | ||
| var productCounter = ProductCounterService.getProductCounter(); | ||
| @Override | ||
| public ResponseMessage countProducts(ProductDto productDto) { |
There was a problem hiding this comment.
the name is not good. maybe create is better name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.