Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cloud profile machineImages validation #943

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix cloud profile machineImages validation #943

wants to merge 1 commit into from

Conversation

hebelsan
Copy link
Contributor

How to categorize this PR?

/area quality
/kind enhancement
/platform openstack

What this PR does / why we need it:
This PR adjusts the CloudProfile validation so that all MachineImages in the CloudProfile map to a valid image in the CloudProfileConfig.
Follow up to gardener/gardener-extension-provider-azure#1020.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Validate that all MachineImages in the CloudProfile map to a valid MachineImage in the CloudProfileConfig

@hebelsan hebelsan requested review from a team as code owners December 23, 2024 13:45
@gardener-robot gardener-robot added needs/review Needs review area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension platform/openstack OpenStack platform/infrastructure size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Dec 23, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 23, 2024
@hebelsan
Copy link
Contributor Author

/hold until the lss script is fixed and only uses valid MachineImage architectures.

@gardener-robot gardener-robot added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Dec 23, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review platform/openstack OpenStack platform/infrastructure reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hebelsan @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot