Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: trigger VPA pipeline on changes in .ci folder #284

Conversation

voelzmo
Copy link
Member

@voelzmo voelzmo commented Jan 8, 2024

What this PR does / why we need it:
Add the .ci folder to the list of triggers for the VPA pipeline. My original intention with leaving this directory out was to avoid automatic pipeline runs when only the .ci folder changed, as this would still use the old pipeline definitions and be therefore not really useful. However, it turns out that the concourse git resource filters out commits that don't match the path property entirely, such that even manual pipeline runs never see this commit.

This is not what we want, therefore let's accept the inconvenience of unnecessary pipeline runs.

Special notes for your reviewer:

Release note:

NONE

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jan 8, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 8, 2024
Copy link

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jan 9, 2024
@rishabh-11 rishabh-11 merged commit 4ea25c8 into gardener:rel-vertical-pod-autoscaler Jan 9, 2024
5 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants