Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suspend CA activities if MCM is offline #256

Merged
merged 13 commits into from
Nov 29, 2023
Merged

Suspend CA activities if MCM is offline #256

merged 13 commits into from
Nov 29, 2023

Conversation

sssash18
Copy link

@sssash18 sssash18 commented Nov 16, 2023 •
edited by rishabh-11
Loading

What this PR does / why we need it:
This PR modifies the Refresh method of CA to suspend CA if MCM is offline.
Which issue(s) this PR fixes:
Fixes #60

Special notes for your reviewer:

Release note:

Cluster Autoscaler will suspend its activities if the machine-controller-manager is offline

@gardener-robot gardener-robot added the needs/review Needs review label Nov 16, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 16, 2023
@gardener-robot gardener-robot added the size/s Size of pull request is small (see gardener-robot robot/bots/size.py) label Nov 16, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 16, 2023
@gardener-robot
Copy link

@unmarshall, @himanshu-kun, @rishabh-11 You have pull request review open invite, please check

@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 21, 2023
@gardener-robot gardener-robot added size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Nov 22, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 22, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 22, 2023
rishabh-11
rishabh-11 requested changes Nov 22, 2023
View reviewed changes
Copy link

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Please address the review comments

cluster-autoscaler/cloudprovider/mcm/mcm_cloud_provider.go Outdated Show resolved Hide resolved
cluster-autoscaler/cloudprovider/mcm/mcm_cloud_provider.go Outdated Show resolved Hide resolved
cluster-autoscaler/cloudprovider/mcm/mcm_cloud_provider_test.go Outdated Show resolved Hide resolved
cluster-autoscaler/cloudprovider/mcm/fakeclient/client.go Outdated Show resolved Hide resolved
cluster-autoscaler/cloudprovider/mcm/mcm_cloud_provider_test.go Outdated Show resolved Hide resolved
cluster-autoscaler/cloudprovider/mcm/test_utils.go Outdated Show resolved Hide resolved
cluster-autoscaler/cloudprovider/mcm/test_utils.go Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Nov 22, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 22, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 22, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 23, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 23, 2023
himanshu-kun
himanshu-kun suggested changes Nov 27, 2023
View reviewed changes
Copy link

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kindly add the IT as we discussed.

@himanshu-kun himanshu-kun self-assigned this Nov 27, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 27, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 27, 2023
@himanshu-kun himanshu-kun removed their assignment Nov 28, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 29, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 29, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 29, 2023
himanshu-kun
himanshu-kun approved these changes Nov 29, 2023
View reviewed changes
Copy link

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes labels Nov 29, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 29, 2023
@himanshu-kun himanshu-kun removed the needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 29, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 29, 2023
rishabh-11
rishabh-11 approved these changes Nov 29, 2023
View reviewed changes
Copy link

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rishabh-11 rishabh-11 merged commit 3799888 into gardener:machine-controller-manager-provider Nov 29, 2023
10 of 16 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 29, 2023
aaronfern pushed a commit to aaronfern/autoscaler that referenced this pull request Dec 11, 2023
@sssash18 @aaronfern
Suspend CA activities if MCM is offline (gardener#256)
a820550 
* Updated refresh func for mcm

* Updated refresh func for mcm

* Struct changes

* Modified Referesh func tests

* Added comment

* Code Refactoring

* deployment rename

* Code refactor and tests rephrase

* Code refactor and tests rephrase

* Refactored a bool condition

* Added IT test for Refresh MCM

* Spell mistake

* Spelling mistake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himanshu-kun himanshu-kun himanshu-kun approved these changes

@rishabh-11 rishabh-11 rishabh-11 approved these changes

@unmarshall unmarshall Awaiting requested review from unmarshall unmarshall is a code owner

Assignees

@sssash18 sssash18

@rishabh-11 rishabh-11

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Safeguard functions of Autoscaler while MCM is offline
7 participants
@sssash18 @gardener-robot @rishabh-11 @himanshu-kun @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3