Upgrade `k8s.io/*` to `v0.28`, `sigs.k8s.io/controller-runtime` to `v0.16` #14

ialidzhikov · 2024-03-26T16:07:54Z

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:
Upgrade k8s.io/* to v0.28, sigs.k8s.io/controller-runtime to v0.16.

The most notable sigs.k8s.io/controller-runtime changes are described in:

Which issue(s) this PR fixes:
Part of #5

Special notes for your reviewer:

It is recommended to review the PR commit by commit.
I decided to drop the units tests for AddToManager funcs: https://github.com/gardener/gardener-custom-metrics/blob/24edc50c613721cce643c6f8a55913da54874198/pkg/input/controller/controller_test.go#L38 and https://github.com/gardener/gardener-custom-metrics/blob/24edc50c613721cce643c6f8a55913da54874198/pkg/input/input_data_service_test.go#L74. The reason is that with the new version of the sigs.k8s.io/controller-runtime dependency we need to do the following change:
```
-	if err := controller.Watch(&source.Kind{Type: args.ControlledObjectType}, &handler.EnqueueRequestForObject{}, args.Predicates...); err != nil {
+	if err := controller.Watch(source.Kind(mgr.GetCache(), args.ControlledObjectType), &handler.EnqueueRequestForObject{}, args.Predicates...); err != nil {
```
The mgr.GetCache() is not used when setting up the watch and this requires to add a fake cache implementation to the fake manager we have. We don't unit test AddToManager funcs in gardener/gardener (or in any other repo). This should be rather covered with e2e tests.
This PR depends on vendor/ dir removal: Drop vendoring #13

Release note:

The following dependencies are updated:
- `k8s.io/*` : `v0.23.17` -> `v0.28.3`
- `sigs.k8s.io/controller-runtime`: `v0.11.2` -> `v0.16.5`

plkokanov · 2024-04-05T13:59:28Z

/unhold
/ok-to-test
The issues with github have been resolved and the adaptations should now be present

…0.16`

…ics-apiserver See gardener-attic#8 (comment)

…th label selectors

plkokanov

/lgtm

gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 26, 2024

gardener-robot added kind/enhancement Enhancement, improvement, extension needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Mar 26, 2024

gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 26, 2024

ialidzhikov force-pushed the enh/update-dependencies branch from 3d81dba to 8727f4d Compare March 27, 2024 12:16

gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 27, 2024

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 27, 2024

ialidzhikov changed the title ~~[WIP] Upgrade k8s.io/* to v0.28, sigs.k8s.io/controller-runtime to v0.16~~ Upgrade k8s.io/* to v0.28, sigs.k8s.io/controller-runtime to v0.16 Mar 27, 2024

ialidzhikov force-pushed the enh/update-dependencies branch from 8727f4d to 9b25d78 Compare March 27, 2024 14:49

gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 27, 2024

gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 27, 2024

gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 27, 2024

ialidzhikov mentioned this pull request Mar 27, 2024

Bump golang.org/x/net from 0.10.0 to 0.17.0 #1

Closed

ialidzhikov force-pushed the enh/update-dependencies branch from cd3375a to 5541a5f Compare March 28, 2024 07:32

gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 28, 2024

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 28, 2024

ialidzhikov marked this pull request as ready for review March 28, 2024 07:34

ialidzhikov requested a review from a team as a code owner March 28, 2024 07:34

ialidzhikov force-pushed the enh/update-dependencies branch from 5541a5f to 4ac8f16 Compare March 28, 2024 08:10

gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 28, 2024

ialidzhikov mentioned this pull request Mar 28, 2024

Code review comments from @ialidzhikov #5

Open

29 tasks

ialidzhikov force-pushed the enh/update-dependencies branch from 4ac8f16 to dbf789d Compare March 31, 2024 17:20

gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 31, 2024

ialidzhikov force-pushed the enh/update-dependencies branch from dbf789d to e2b4956 Compare April 2, 2024 10:27

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 5, 2024

gardener-robot removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Apr 5, 2024

plkokanov added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 5, 2024

ialidzhikov added 14 commits April 8, 2024 09:36

[prerequisite] Drop the unused client field from the actuators

bd5fe30

[prerequisite] Drop dependency injection funcs

55fa1dd

Upgrade k8s.io/* to v0.28, sigs.k8s.io/controller-runtime to `v…

2f8582a

…0.16`

Adapt to the breaking change in the manager.Options struct

38e2e0b

Adapt to the breaking change how the watch is being set up

12b66ac

Use the upstream fake client instead of a custom fake manager

4783272

Drop unit tests for AddNewControllerToManager

7d924ca

Use k8s.io/utils/ptr instead of the deprecated k8s.io/utils/pointer pkg

86d8456

Use the upstream fake client instead of the custom fake client

36931e3

Drop the custom fake client

33848c2

Drop the fake manager

f1ab044

Use consistent naming for the manager

30abc9f

Drop custom OpenAPIConfig instead of the default one from custom-metr…

4f204e7

…ics-apiserver See gardener-attic#8 (comment)

Adapt to the breaking change how the cache is restricted to object wi…

f082b3b

…th label selectors

ialidzhikov force-pushed the enh/update-dependencies branch from 1335707 to f082b3b Compare April 8, 2024 06:43

gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 8, 2024

plkokanov approved these changes Apr 9, 2024

View reviewed changes

gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Apr 9, 2024

gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 9, 2024

ialidzhikov merged commit 7346aef into gardener-attic:main Apr 10, 2024
5 checks passed

ialidzhikov deleted the enh/update-dependencies branch April 10, 2024 06:00

gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Apr 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade `k8s.io/*` to `v0.28`, `sigs.k8s.io/controller-runtime` to `v0.16` #14

Upgrade `k8s.io/*` to `v0.28`, `sigs.k8s.io/controller-runtime` to `v0.16` #14

ialidzhikov commented Mar 26, 2024 •

edited

Loading

plkokanov commented Apr 5, 2024

plkokanov left a comment

Upgrade k8s.io/* to v0.28, sigs.k8s.io/controller-runtime to v0.16 #14

Upgrade k8s.io/* to v0.28, sigs.k8s.io/controller-runtime to v0.16 #14

Conversation

ialidzhikov commented Mar 26, 2024 • edited Loading

plkokanov commented Apr 5, 2024

plkokanov left a comment

Choose a reason for hiding this comment

Upgrade `k8s.io/*` to `v0.28`, `sigs.k8s.io/controller-runtime` to `v0.16` #14

Upgrade `k8s.io/*` to `v0.28`, `sigs.k8s.io/controller-runtime` to `v0.16` #14

ialidzhikov commented Mar 26, 2024 •

edited

Loading