perf: improve preprocess action perf by capturing context instead of partially resolving template strings #6745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partially resolving template strings
stefreak
commented
Jan 2, 2025
| ...config, | ||
| ...resolvedBuiltin, | ||
| spec, | ||
| } |
There was a problem hiding this comment.
TODO: can we somehow keep early validation? Is it dangerous to remove?
stefreak
commented
Jan 2, 2025
| const resolvedDeps = capture( | ||
| rawConfig.build.dependencies as unknown as ParsedTemplate, | ||
| configContext | ||
| ) as unknown as BuildDependencyConfig | ||
|
|
||
| // The build.dependencies field may not resolve at all, in which case we can't extract any deps from there | ||
| if (isArray(resolvedDeps)) { |
There was a problem hiding this comment.
todo: this branch needs adaptation, as we do not resolve dependencies anymore.
There was a problem hiding this comment.
do dependencies need to be fully resolved? If partial is ok, is it then fine not to resolve them at all?
The yaml highlighting did not work in production builds anyway and removing this functionality made it easier to compare performance between production builds and the dev build for commands like `get graph`.
stefreak
force-pushed
the
preprocess-perf
branch
from
99f72e9 to
cb0081c
Compare
fail early if we access an unresolved template value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: