chore: stricter return type in ConfigStore.get(...)
#5953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signature `get<S extends keyof I<T>, K extends keyof I<T>[S]>(section: S, key: K)` may return `undefined` because the `key` parameter is a dynamic value, that might not exist in the config store. See `CloudApi.getStoredAuthToken()`. It can return `undefined` and we check it in `CloudApi.factory()`.
stefreak
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The signature
get<S extends keyof I<T>, K extends keyof I<T>[S]>(section: S, key: K)may returnundefinedbecause thekeyparameter is a dynamic value, that might not exist in the config store.See
CloudApi.getStoredAuthToken().It can return
undefinedand we check it inCloudApi.factory().Which issue(s) this PR fixes:
Prevents potential runtime
undefined-errors.Special notes for your reviewer:
I figured this out while reviewing #5502.