Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tst/testall.g to quit GAP with exit status indicating outcome #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fingolfin
Copy link
Member

This is what we want for e.g. tests in the package distro

This is what we want for e.g. tests in the package distro
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.22%. Comparing base (77840f6) to head (d5915b1).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   93.71%   93.22%   -0.50%     
==========================================
  Files           3        3              
  Lines         175      177       +2     
==========================================
+ Hits          164      165       +1     
- Misses         11       12       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fingolfin
Copy link
Member Author

This causes CI to pass but only because we now quit GAP with an exit code in tst/testall.g. But the second GAP process that gets launched from the primary GAP still runs into an error; it just doesn't get reported back to the top level GAP ...

I don't like papering over the issue, so I'll not merge this for now

@fingolfin
Copy link
Member Author

Ah, the failures are not new: #22

@fingolfin fingolfin closed this Nov 6, 2024
@fingolfin fingolfin reopened this Nov 6, 2024
@fingolfin
Copy link
Member Author

The test file is not very useful right now either (other than showing that the test setup is broken). @RussWoodroofe added in PR #16 (thanks you!), but right now all it does is run all tests in .tst files -- of which there are none.

But more worryingly, this test setup relies on the GAP function InputOutputLocalProcess. As described here this function is quite limited and among other problems does not allow querying the exit status of the subprocess. So there is fundamentally no way to do that as a check.

Right now the only way for a complete solution I can think of is to replace this test setup by a different one that is not driven by GAP, but rather by python/perl/a shell script/whatever.

That said, perhaps we can come up with a way to at least patch this enough to be useful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant