Skip to content

Commit

Permalink
LIBTOMKNOWN.STDGEN -> LIBTOM_STDGEN (#34)
Browse files Browse the repository at this point in the history
Move STDGEN and CheckSTDGEN out of the LIBTOMKNOWN record,
which now is flushable.
  • Loading branch information
fingolfin authored Jan 12, 2024
1 parent f43c3b5 commit 78ad59d
Show file tree
Hide file tree
Showing 5 changed files with 26 additions and 14 deletions.
5 changes: 0 additions & 5 deletions gap/tmadmin.tmd
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,6 @@
## is it allowed to remove previously loaded library files
## (is set to <K>true</K> by default),
## </Item>
## <Mark><C>STDGEN</C> </Mark>
## <Item>
## a list describing standard generators of almost simple groups in the
## table of marks library.
## </Item>
## </List>
## <P/>
## Additionally the names of the files already loaded occur as components of
Expand Down
2 changes: 1 addition & 1 deletion gap/tmadmin.tmi
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ InstallGlobalFunction( LIBTOM, function( arg )
record.UnderlyingGroup:= GroupWithGenerators( record.UnderlyingGroup );

# If standard generators are known then store them in the table.
for entry in LIBTOMKNOWN.STDGEN do
for entry in LIBTOM_STDGEN do
if record.Identifier = entry[1] then
record.StandardGeneratorsInfo:= [ rec(
generators := entry[3],
Expand Down
14 changes: 7 additions & 7 deletions gap/tmstdrd.tom
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
## This file contains the descriptions of standard generators of tables of
## marks in the TomLib package.
##
## Each entry in the list `LIBTOMKNOWN.STDGEN' is a list of length 4 or 6.
## Each entry in the list `LIBTOM_STDGEN' is a list of length 4 or 6.
## - At the first position the `Identifier' value of the table of marks
## is stored.
## - The value at the second position is either the string "N" or a positive
Expand Down Expand Up @@ -36,7 +36,7 @@
## Representations (w.r.t. standardization 1).
##

LIBTOMKNOWN.STDGEN := [
BindGlobal("LIBTOM_STDGEN", [

["A5", 1, "a, b",
"|a|=2, |b|=3, |ab|=5" ],
Expand Down Expand Up @@ -563,22 +563,22 @@ LIBTOMKNOWN.STDGEN := [
["Co3", 1, "a, b",
"|y|=9, y^3=a, |z|=20, z^5=b, |ab|=14" ],

];
]);


#############################################################################
##
#F LIBTOMKNOWN.CheckSTDGEN( [<entry>] )
#F LIBTOM_CheckSTDGEN( [<entry>] )
##
LIBTOMKNOWN.CheckSTDGEN:= function( arg )
LIBTOM_CheckSTDGEN:= function( arg )
local result, entry, name, tom, info, flag, atlasname, tomgroup, tomgens,
check, is_std, atlasgroup, atlasgens, inforec, hom, res;

result:= true;

if Length( arg ) = 0 then
for entry in LIBTOMKNOWN.STDGEN do
result:= LIBTOMKNOWN.CheckSTDGEN( entry ) and result;
for entry in LIBTOM_STDGEN do
result:= LIBTOM_CheckSTDGEN( entry ) and result;
od;
return result;
fi;
Expand Down
2 changes: 1 addition & 1 deletion read.g
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
##

# Read the implementation part.
ReadPackage( "tomlib", "gap/tmadmin.tmi" );
ReadPackage( "tomlib", "gap/tmstdrd.tom" );
ReadPackage( "tomlib", "gap/tmadmin.tmi" );
#ReadPackage( "tomlib", "gap/test.gi" );

ReadPackage( "tomlib", "gap/stdgen.gi" );
Expand Down
17 changes: 17 additions & 0 deletions tst/bugfix.tst
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,22 @@ gap> g:= UnderlyingGroup( t );;
gap> IsConjugate( g, RepresentativeTom( t, 39 ), RepresentativeTom( t, 43 ) );
false

# Verify that code in the GAP library using tomlib actually works...
gap> G := GL(2,5);;
gap> msc := MaximalSubgroupClassReps(G);;
gap> ForAll(msc, H -> Parent(H) = G);
true
gap> SortedList(List(msc, IndexInParent));
[ 2, 5, 6, 10 ]

# ... and still works after flushing caches
gap> FlushCaches();
gap> G := GL(2,5);;
gap> msc := MaximalSubgroupClassReps(G);;
gap> ForAll(msc, H -> Parent(H) = G);
true
gap> SortedList(List(msc, IndexInParent));
[ 2, 5, 6, 10 ]

#
gap> STOP_TEST( "bugfix.tst", 1 );

0 comments on commit 78ad59d

Please sign in to comment.