Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor (WIP -- DO NOT MERGE YET) #13

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

markuspf
Copy link
Member

@markuspf markuspf commented Feb 7, 2018

This is mainly to move some code to the OpenMath package and do some cleanup of whitespace and indentation

@markuspf markuspf changed the title Refactor OMGetObjectWithAttributes (step 1/n) (WIP -- DO NOT MERGE YET) Refactor (WIP -- DO NOT MERGE YET) Feb 7, 2018
@codecov
Copy link

codecov bot commented Feb 8, 2018

Codecov Report

Merging #13 into master will not change coverage.
The diff coverage is 49.81%.

@@           Coverage Diff           @@
##           master      #13   +/-   ##
=======================================
  Coverage   41.06%   41.06%           
=======================================
  Files          14       14           
  Lines        1914     1914           
=======================================
  Hits          786      786           
  Misses       1128     1128
Impacted Files Coverage Δ
lib/openmath.g 49.63% <49.23%> (ø) ⬆️
lib/process.gi 32.92% <80%> (ø) ⬆️

@olexandr-konovalov
Copy link
Member

This now has conflicts after merging #16. How does this PR evolve now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants