close the stream in PqDescendants
#65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise the process is still running, and calling `PqDescendants` too many times will result in a `"failed to launch child process"` error in `PQ_START`.
|
@fingolfin Perhaps this fix (or a better one) would also be interesting for the forthcoming GAP release. |
fingolfin
approved these changes
Oct 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #65 +/- ##
==========================================
+ Coverage 16.55% 16.59% +0.04%
==========================================
Files 146 146
Lines 12835 12838 +3
Branches 1934 1934
==========================================
+ Hits 2125 2131 +6
+ Misses 10706 10703 -3
Partials 4 4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise the process is still running,
and calling
PqDescendantstoo many times will result in a"failed to launch child process"error inPQ_START.