remove useSession

gaoyan1998 · Oct 10, 2023 · 8ed12b9 · 8ed12b9
1 parent 270920b
commit 8ed12b9
Show file tree

Hide file tree

Showing 7 changed files with 0 additions and 22 deletions.
diff --git a/dinky-admin/src/main/java/org/dinky/data/dto/APIExecuteSqlDTO.java b/dinky-admin/src/main/java/org/dinky/data/dto/APIExecuteSqlDTO.java
@@ -125,7 +125,6 @@ public JobConfig getJobConfig() {
                 .useResult(useResult)
                 .useChangeLog(useChangeLog)
                 .useAutoCancel(useAutoCancel)
-                .useSession(false)
                 .useRemote(true)
                 .address(address)
                 .jobName(jobName)

diff --git a/dinky-admin/src/main/java/org/dinky/data/dto/APIExplainSqlDTO.java b/dinky-admin/src/main/java/org/dinky/data/dto/APIExplainSqlDTO.java
@@ -58,7 +58,6 @@ public class APIExplainSqlDTO extends AbstractStatementDTO {
     public JobConfig getJobConfig() {
         return JobConfig.builder()
                 .type(GatewayType.LOCAL.getLongValue())
-                .useSession(false)
                 .useRemote(false)
                 .fragment(isFragment())
                 .statementSet(useStatementSet)

diff --git a/dinky-admin/src/main/java/org/dinky/data/dto/TaskDTO.java b/dinky-admin/src/main/java/org/dinky/data/dto/TaskDTO.java
@@ -226,13 +226,6 @@ public class TaskDTO extends AbstractStatementDTO {
             notes = "Flag indicating whether to use auto-canceling")
     private boolean useAutoCancel;
 
-    @ApiModelProperty(
-            value = "Use Session",
-            dataType = "boolean",
-            example = "false",
-            notes = "Flag indicating whether to use a session")
-    private boolean useSession;
-
     @ApiModelProperty(value = "Session", dataType = "String", example = "session_id", notes = "The session identifier")
     private String session;
 

diff --git a/dinky-admin/src/main/java/org/dinky/service/impl/StudioServiceImpl.java b/dinky-admin/src/main/java/org/dinky/service/impl/StudioServiceImpl.java
@@ -91,10 +91,6 @@ public JdbcSelectResult getCommonSqlData(Integer taskId) {
     @Override
     public IResult executeDDL(StudioDDLDTO studioDDLDTO) {
         JobConfig config = studioDDLDTO.getJobConfig();
-        if (!config.isUseSession()) {
-            config.setAddress(
-                    clusterInstanceService.buildEnvironmentAddress(config.isUseRemote(), studioDDLDTO.getClusterId()));
-        }
         JobManager jobManager = JobManager.build(config);
         return jobManager.executeDDL(studioDDLDTO.getStatement());
     }

diff --git a/dinky-core/src/main/java/org/dinky/explainer/Explainer.java b/dinky-core/src/main/java/org/dinky/explainer/Explainer.java
@@ -365,7 +365,6 @@ public JobPlanInfo getJobPlanInfo(String statement) {
     public List<LineageRel> getLineage(String statement) {
         JobConfig jobConfig = JobConfig.builder()
                 .type(GatewayType.LOCAL.getLongValue())
-                .useSession(false)
                 .useRemote(false)
                 .fragment(true)
                 .statementSet(useStatementSet)

diff --git a/dinky-core/src/main/java/org/dinky/job/JobConfig.java b/dinky-core/src/main/java/org/dinky/job/JobConfig.java
@@ -110,13 +110,6 @@ public class JobConfig {
             notes = "Flag indicating whether to use auto-cancel")
     private boolean useAutoCancel;
 
-    @ApiModelProperty(
-            value = "Flag indicating whether to use session",
-            dataType = "boolean",
-            example = "true",
-            notes = "Flag indicating whether to use session")
-    private boolean useSession;
-
     @ApiModelProperty(
             value = "Session information",
             dataType = "String",

diff --git a/dinky-core/src/test/java/org/dinky/core/JobManagerTest.java b/dinky-core/src/test/java/org/dinky/core/JobManagerTest.java
@@ -49,7 +49,6 @@ public void cancelJobSelect() {
                 .useResult(true)
                 .useChangeLog(true)
                 .useAutoCancel(true)
-                .useSession(true)
                 .session("s1")
                 .clusterId(2)
                 .jobName("Test")