Fix & Feat Client App [Notification]

[+] fix(update.ts): remove unnecessary notification sending when permission is not granted [+] feat(update.ts): add notification for already up to date version
gaogao1030 · Oct 3, 2023 · ddfd05b · ddfd05b
1 parent d2ad01a
commit ddfd05b
Showing 1 changed file with 18 additions and 14 deletions.
diff --git a/app/store/update.ts b/app/store/update.ts
@@ -86,24 +86,28 @@ export const useUpdateStore = createPersistStore(
           // Check if notification permission is granted
           await window.__TAURI__?.notification.isPermissionGranted().then((granted) => {
             if (!granted) {
-              // Send a notification without waiting for permission (because we don't neeed a permisison once client is already click "check")
-              window.__TAURI__?.notification.sendNotification({
-                title: "ChatGPT Next Web",
-                body: `A new version (${remoteId}) is available.`,
-                icon: `${ChatGptIcon.src}`,
-                sound: "Default"
-              });
+              return
             } else {
               // Request permission to show notifications
               window.__TAURI__?.notification.requestPermission().then((permission) => {
                 if (permission === 'granted') {
-                  // Show a notification using Tauri
-                  window.__TAURI__?.notification.sendNotification({
-                    title: "ChatGPT Next Web",
-                    body: `A new version (${remoteId}) is available.`,
-                    icon: `${ChatGptIcon.src}`,
-                    sound: "Default"
-                  });
+                  if (version === remoteId) {
+                    // Show a notification using Tauri
+                    window.__TAURI__?.notification.sendNotification({
+                      title: "ChatGPT Next Web",
+                      body: "Already up to date",
+                      icon: `${ChatGptIcon.src}`,
+                      sound: "Default"
+                    });
+                  } else {
+                    // Show a notification for the new version using Tauri
+                    window.__TAURI__?.notification.sendNotification({
+                      title: "ChatGPT Next Web",
+                      body: `A new version (${remoteId}) is available.`,
+                      icon: `${ChatGptIcon.src}`,
+                      sound: "Default"
+                    });
+                  }
                 }
               });
             }