Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (icon list block): fix error on transform for saved icon list block #3285

Merged
merged 2 commits into from
Sep 5, 2024
+5 −1
Merged

Fix (icon list block): fix error on transform for saved icon list block #3285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8587600
disable saved styles for icon list item
mxkae Aug 8, 2024
b0715eb
fix error on transform for saved icon list block
mxkae Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/block/icon-list-item/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ export const settings = {
supports: {
anchor: true,
__experimentalSelector: 'li',
reusable: false,
stkSaveBlockStyle: false,
},
example,
edit,
Expand Down
4 changes: 3 additions & 1 deletion src/hooks/use-saved-default-block-style.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,9 @@ export const useSavedDefaultBlockStyle = blockProps => {
} )

// Create and apply the innerBlocks.
if ( blockData.innerBlocks?.length ) {
// Do not do this for icon lists because it causes an error on transform.
// The icon list inner blocks are created by the icon list block itself. See src/blocks/icon-list/transforms.js
if ( blockData.innerBlocks?.length && name !== 'stackable/icon-list' ) {
const innerBlocks = createBlocksFromInnerBlocksTemplate( blockData.innerBlocks )
// We need to add unique Ids to prevent the default styles from getting applied.
recursivelyAddUniqueIdToInnerBlocks( innerBlocks )
Expand Down
Loading