Contract L1 Chain #1227
Merged
Contract L1 Chain #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radazen
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Looks awesome, @benny-conn! I love the direction we're going with this. 🚀 🚀 🚀
db/queries/core/contract_gallery.sql
Outdated
| , unnest(@description::varchar[]) | ||
| , unnest(@profile_image_url::varchar[]) | ||
| , unnest(@provider_marked_spam::bool[]) | ||
| ) | ||
| on conflict (chain, address) where parent_id is null | ||
| on conflict (l1_chain, address) where parent_id is null |
There was a problem hiding this comment.
Can there be multiple contracts at the same address across L2 chains? This looks like it'd essentially merge all contracts at the same address across L2 chains if they're on the same L1, but that sounds okay to me as long as it's a valid thing to actually do! I defer to your blockchain expertise here.
There was a problem hiding this comment.
You are in fact correct, although infinitesimally improbable, it can happen. Modified the index to include both l1_chain and chain.
service/multichain/multichain.go
Outdated
| Chain: ti.Chain, | ||
| L1CHain: ti.Chain.L1Chain(), |
| @@ -266,7 +266,7 @@ func (p *Personalization) update(ctx context.Context) { | |||
|
|
|||
| if p.pM == nil { | |||
| logger.For(ctx).Infof("no data loaded, reading from cache") | |||
| p.readCache(ctx) | |||
| // p.readCache(ctx) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
L1Chainto the contracts tablecontract_creatorsview to use theL1Chainof thewalletsandcontractstableTODO: