Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very much still work in progress. This is as yet untested, but I am putting it online because I cannot currently find the recommendations of how this should be integrated and need some input.
Should I leave the torch code as an independent
core_torch
file and keep it minimal?Another option is to try to operate with backends, since the files do not differ that much, but that would involve a lot more work, and modifications to the remaining code.
Any input appreciated, since I currently don't have the big picture.