Rails 4 compatibilty #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
1 similar comment
|
+1 |
|
It would be great to accept this PR. |
|
+1 |
…ls.env.test? extracted
|
Everyone who is still interested: We fixed some issues, made some Travis CI specs, bumped the version number over on https://github.com/pludoni/simple-captcha. Unfortunatly, both galethub and the original author did not respond to my messages :(. To use it, just reference the git: gem 'simple_captcha', :git => 'git://github.com/pludoni/simple-captcha.git'Contributions (preferable with tests) are very welcome :) |
As I can see we _always_ need to use dummy app for testing.
Correct contributing part of README according to travis config
Fix default gemfile for dummy application
To prevent some "unused variable" warnings.
``` warning: instance variable @_simple_captcha_result not initialized ```
Rails 5 support
… available refresh_formats and raise error if adapter not available, cleaned up code
would allow people to fix the issues raised in #52
Allow manual font family overrides
added debian hint
Fix headers in Readme.md
Specify the font before the label to avoid issues
Support running tests with Rails 5.2
Support Sequel ORM
DeadLock in captcha deletion dosn't break process
add license
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
@Azdaroth started a Rails-4 branch, to make SimpleCaptcha compatible with Rails 4 final.
We made some minor adjustments and are already running SimpleCaptcha in a Rails 4 production app now.
Maybe this is useful for other people as well.