Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: WebDriver-session was overriden #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: WebDriver-session was overriden #3

wants to merge 1 commit into from

Commits on Mar 28, 2017

  1. Fix: DriverSession was overriden 

    The previous version seemed not to be thread-safe since a NoSuchSessionException sometimes occurred when running tests in parallel in a Selenium Grid. This seems to be caused by an override of the driver property of the device from another thread, causing two tests to use the same WebDriver-session which in turn leads to an Exception when the first test to finish closes the driver-session. By only accessing the driver through the TestSession (where it is set anyway, see also https://github.com/galenframework/galen-bootstrap/blob/master/galen-bootstrap/galen-bootstrap.js#L94), we can avoid using a non-thread-local driver instance.
    @dnlkng
    dnlkng authored Mar 28, 2017
    Configuration menu
    Copy the full SHA
    8286d6d View commit details
    Browse the repository at this point in the history