Cleanup Jest Test Output (part 2) #19178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think the test meant to issue the error so I fixed the call and I instrumented the queue to ensure errors don't happen in any of the tests.
An actual bug and the hack to work around Vue 2 warning in useMagicKeys.
See comments inline for how to test this works and my best shot at the explaining the problem.
dannon
reviewed
Nov 21, 2024
Co-authored-by: Dannon <[email protected]>
davelopez
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Thank you so much for all the cleaning!
I've rerun the client tests that were failing and they are passing now:
https://github.com/galaxyproject/galaxy/actions/runs/11958564319/job/33338362283?pr=19178
Likely because of the random nature of:
A worker process has failed to exit gracefully and has been force exited. This is likely caused by tests leaking due to improper teardown. Try running with --detectOpenHandles to find leaks. Active timers can also cause this, ensure that .unref() was called on them.
There are many more things in the test output that can be fixed, but this is already a HUGE improvement! We can continue iterating on the cleanup in smaller chunks.
Thank you!
3 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo and expansion of #19164.
How to test the changes?
(Select all options that apply)
License