Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22.01] Don't create a BGZF index when running the compressing converter #13991

Merged

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Jun 1, 2022

Backport of #13969

The index file is not used because it is generated again in set_meta()
for the VcfGz datatype, and ignored for all others.

Additionally, the index file is currently generated alongside the input
dataset, which fails when the input directory is not writeable (such as
when running in a container).

Fix #13916 .

Also, replace outdated tabix requirement with the latest htslib.

(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these contributions under Galaxy's current license.
  • I agree to allow the Galaxy committers to license these and all my past contributions to the core galaxy codebase under the MIT license. If this condition is an issue, uncheck and just let us know why with an e-mail to [email protected].

The index file is not used because it is generated again in `set_meta()`
for the `VcfGz` datatype, and ignored for all others.

Additionally, the index file is currently generated alongside the input
dataset, which fails when the input directory is not writeable (such as
when running in a container).

Fix galaxyproject#13916 .

Also, replace outdated `tabix` requirement with the latest `htslib`.
@mvdbeek mvdbeek merged commit 55a8ab1 into galaxyproject:release_22.01 Jun 2, 2022
@nsoranzo nsoranzo deleted the backport_compression_converter branch June 2, 2022 15:08
@nsoranzo nsoranzo added this to the 22.01 milestone Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants