Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21.09] Fix collection population error handling #13728

Conversation

davelopez
Copy link
Contributor

Fixes #13607

This is a naive attempt at fixing the display of failed collections produced by a tool run.
I'm not very comfortable with Backbone, so maybe there are smarter ways of fixing this?

Before the changes:

collectionErrorBefore

After the changes:

collectionErrorAfter

How to test the changes?

License

  • I agree to license these contributions under Galaxy's current license.
  • I agree to allow the Galaxy committers to license these and all my past contributions to the core galaxy codebase under the MIT license. If this condition is an issue, uncheck and just let us know why with an e-mail to [email protected].

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
The backend returns `failed` and not `error` as `populated_state`
- Display `populated_state_message` as description when the populated_state is `failed`
This is a temporal hack for the legacy history panel. It needs to be correctly handled in the new history.
@bgruening
Copy link
Member

The failing test is unrelated.

@mvdbeek mvdbeek merged commit b924a86 into galaxyproject:release_21.09 Apr 15, 2022
@davelopez davelopez deleted the 21.09_fix_collection_error_handling branch April 15, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants