Quote conda prefix in install command #13070
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Installing conda into a path with a space doesn't work at all ... https://github.com/mvdbeek/galaxy/runs/4549243765?check_suite_focus=true#step:11:1590 |
Yep, I know, I have an open PR to fix that since May: conda/constructor#449 |
nsoranzo
reviewed
Dec 16, 2021
| @@ -431,7 +431,7 @@ def install_conda(conda_context, force_conda_build=False): | |||
| with tempfile.NamedTemporaryFile(suffix=".sh", prefix="conda_install", delete=False) as temp: | |||
| script_path = temp.name | |||
| download_cmd = commands.download_command(conda_link(), to=script_path) | |||
| install_cmd = ['bash', script_path, '-b', '-p', conda_context.conda_prefix] | |||
| install_cmd = ['bash', script_path, '-b', '-p', shlex.quote(conda_context.conda_prefix)] | |||
There was a problem hiding this comment.
I'm quite sure this is not necessary, and actually breaks it if conda_context.conda_prefix contains a space. E.g.:
In [1]: import shlex
In [2]: from galaxy.util.commands import shell
In [3]: shell(["ls", "/tmp/galaxy root"])
foo
Out[3]: 0
In [4]: shell(["ls", shlex.quote("/tmp/galaxy root")])
ls: cannot access "'/tmp/galaxy root'": No such file or directory
Out[4]: 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can see this fail in our first_startup tests at https://github.com/galaxyproject/galaxy/runs/4547495148?check_suite_focus=true#step:11:1827
How to test the changes?
(Select all options that apply)
License