This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
Fixing test failures - Add snakeyaml dependency to MVP #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
The tests in our suite that use the MVP zipped distribution of Galasa are currently failing. The snakeyaml dependency is not part of the MVP zip and so when these tests attempt to pull the artefact, they have to reach out to Maven Central. At this point, they are getting a timeout and so the test is failing.
This PR adds snakeyaml into the MVP zip so that this failure hopefully doesn't reoccur. Not sure why the timeout when contacting Maven Central is happening, but any MVP tests shouldn't need to contact it anyway.