-
Notifications
You must be signed in to change notification settings - Fork 12
Added test report generation/uploading , fixed java version, added workflow triggers #170
Conversation
Signed-off-by: dhruv <[email protected]>
Signed-off-by: dhruv <[email protected]>
Signed-off-by: dhruv <[email protected]>
testing report generation
Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of changes but overall good stuff thanks - as well as the changes mentioned, please can you:
- Change the upload of the build logs to only if failure and add a retention policy of 7 days
- Add the upload of the build logs to the PR build too (Reason explained on your Managers PR)
Signed-off-by: dhruv <[email protected]>
Signed-off-by: dhruv <[email protected]>
Made required changes
Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building' |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for building
GH workflow fails as Dhruv's namespace doesn't have access to our Maven GPG secrets referenced in the workflow. |
Build successful |
For issue