-
Notifications
You must be signed in to change notification settings - Fork 12
Added Build and Pr build github actions workflow #157
Conversation
Signed-off-by: dhruv <[email protected]>
Signed-off-by: dhruv <[email protected]>
Signed-off-by: dhruv <[email protected]>
Signed-off-by: dhruv <[email protected]>
Signed-off-by: dhruv <[email protected]>
Signed-off-by: dhruv <[email protected]>
Signed-off-by: dhruv <[email protected]>
Signed-off-by: dhruv <[email protected]>
Signed-off-by: dhruv <[email protected]>
Signed-off-by: dhruv <[email protected]>
Signed-off-by: dhruv <[email protected]>
Signed-off-by: dhruv <[email protected]>
Signed-off-by: dhruv <[email protected]>
Signed-off-by: dhruv <[email protected]>
Signed-off-by: dhruv <[email protected]>
Signed-off-by: dhruv <[email protected]>
initial commit
Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building' |
Signed-off-by: dhruv <[email protected]>
Signed-off-by: dhruv <[email protected]>
Signed-off-by: dhruv <[email protected]>
Signed-off-by: dhruv <[email protected]>
edited pr build workflow
Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building' |
Signed-off-by: dhruv <[email protected]>
added custom settings.xml
Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building' |
Signed-off-by: dhruv <[email protected]>
edit: namespace
Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Dhruv, good start but a few minor changes, mostly to correct image locations so we are using the new GHCR images we have built from the other workflows, and to accurately label the names of the steps in the workflow so when you view it at a high level, it's clear what the different steps are doing, instead of them being labelled all the same. Please make these changes then I can approve the PR workflow to run as part of this PR.
Signed-off-by: dhruv <[email protected]>
made required changes
Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for building
Build successful |
For issue galasa-dev/projectmanagement#1881