Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Added Build and Pr build github actions workflow #157

Merged
merged 28 commits into from
Jul 30, 2024

Conversation

jaydee029
Copy link
Contributor

@jaydee029 jaydee029 commented Jul 26, 2024

jaydee029 and others added 17 commits July 26, 2024 12:57
Signed-off-by: dhruv <[email protected]>
Signed-off-by: dhruv <[email protected]>
@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

jaydee029 and others added 2 commits July 29, 2024 10:32
@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

jaydee029 and others added 2 commits July 29, 2024 14:30
@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

Copy link
Contributor

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Dhruv, good start but a few minor changes, mostly to correct image locations so we are using the new GHCR images we have built from the other workflows, and to accurately label the names of the steps in the workflow so when you view it at a high level, it's clear what the different steps are doing, instead of them being labelled all the same. Please make these changes then I can approve the PR workflow to run as part of this PR.

.github/workflows/pr-build.yaml Outdated Show resolved Hide resolved
.github/workflows/pr-build.yaml Outdated Show resolved Hide resolved
.github/workflows/pr-build.yaml Outdated Show resolved Hide resolved
.github/workflows/pr-build.yaml Outdated Show resolved Hide resolved
.github/workflows/pr-build.yaml Outdated Show resolved Hide resolved
.github/workflows/pr-build.yaml Outdated Show resolved Hide resolved
.github/workflows/pr-build.yaml Outdated Show resolved Hide resolved
.github/workflows/pr-build.yaml Outdated Show resolved Hide resolved
dockerfiles/dockerfile.javadocmavenrepo Outdated Show resolved Hide resolved
dockerfiles/dockerfile.obr Outdated Show resolved Hide resolved
jaydee029 and others added 2 commits July 30, 2024 13:32
@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

Copy link
Contributor

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for building

@galasa-team
Copy link

Build successful

@jadecarino jadecarino merged commit 63d8731 into galasa-dev:main Jul 30, 2024
4 of 5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants