Build isolated.tar files manually #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jade Carino <[email protected]>
Signed-off-by: Jade Carino <[email protected]>
Signed-off-by: Jade Carino <[email protected]>
Signed-off-by: Jade Carino <[email protected]>
Signed-off-by: Jade Carino <[email protected]>
Signed-off-by: Jade Carino <[email protected]>
Signed-off-by: Jade Carino <[email protected]>
Signed-off-by: Jade Carino <[email protected]>
techcobweb
approved these changes
Dec 4, 2024
eamansour
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
When doing some prerelease testing of the Isolated/MVP zip contents, by using the isolated.tar according to the instructions on galasa.dev, I found that the isolated.tar in both zips was broken. When you run
docker load -i isolated.tarthe response should say something likeLoaded image:...but it saidopen /var/lib/docker/tmp/docker-import-4172513240/bin/json: no such file or directory.From investigation in PR #85 I found that the isolated.tar is corrupted from the moment its built in the GH workflow - so the docker
build-push-actionmust not be building it correctly.This PR changes the build of the isolated.tar to use
docker savewhich is simpler anyway and achieves the same thing, and builds an uncorrupted tar file (I've tested it locally against the galasa.dev instructions).Note: discussion with @techcobweb decided we should not rename the isolated.tar for the MVP to mvp.tar as it might be confusing for users as all previous communication refers only to isolated.tar.