Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pom versions to resolve httpclient-osgi and commons-codec #81

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

eamansour
Copy link
Member

@eamansour eamansour commented Dec 2, 2024

Why?

Changes in #80 revealed more errors when resolving httpcomponents and commons-codec dependencies as shown below because these versions were recently changed in the core galasa codebase.

* What went wrong:
Execution failed for task ':compileJava'.
> Could not resolve all files for configuration ':compileClasspath'.
   > Could not resolve commons-codec:commons-codec:1.16.1.
     Required by:
         project :
      > Could not resolve commons-codec:commons-codec:1.16.1.
         > Could not parse POM /home/galasa38/galasaconfig/isolatedrepo/maven/commons-codec/commons-codec/1.16.1/commons-codec-1.16.1.pom
            > Could not find org.apache.commons:commons-parent:66.
              Searched in the following locations:
                - file:/home/galasa38/galasaconfig/isolatedrepo/maven/org/apache/commons/commons-parent/66/commons-parent-66.pom
              If the artifact you are trying to retrieve can be found in the repository but without metadata in 'Maven POM' format, you need to adjust the 'metadataSources { ... }' of the repository declaration.
   > Could not find org.apache.httpcomponents:httpcore:4.4.16.
     Searched in the following locations:
       - file:/home/galasa38/galasaconfig/isolatedrepo/maven/org/apache/httpcomponents/httpcore/4.4.16/httpcore-4.4.16.pom
     If the artifact you are trying to retrieve can be found in the repository but without metadata in 'Maven POM' format, you need to adjust the 'metadataSources { ... }' of the repository declaration.
     Required by:
         project :
   > Could not find org.apache.httpcomponents:httpclient:4.5.14.
     Searched in the following locations:
       - file:/home/galasa38/galasaconfig/isolatedrepo/maven/org/apache/httpcomponents/httpclient/4.5.14/httpclient-4.5.14.pom
     If the artifact you are trying to retrieve can be found in the repository but without metadata in 'Maven POM' format, you need to adjust the 'metadataSources { ... }' of the repository declaration.
     Required by:
         project : > dev.galasa:dev.galasa.core.manager:0.38.0 > dev.galasa:dev.galasa.platform:0.38.0
         project : > dev.galasa:dev.galasa.http.manager:0.38.0 > dev.galasa:dev.galasa.wrapping.httpclient-osgi:0.38.0
   > Could not resolve commons-codec:commons-codec:1.16.1.
     Required by:
         project : > dev.galasa:dev.galasa.core.manager:0.38.0 > dev.galasa:dev.galasa.platform:0.38.0
         project : > dev.galasa:dev.galasa.http.manager:0.38.0 > dev.galasa:dev.galasa.wrapping.httpclient-osgi:0.38.0
      > Could not resolve commons-codec:commons-codec:1.16.1.
         > Could not parse POM /home/galasa38/galasaconfig/isolatedrepo/maven/commons-codec/commons-codec/1.16.1/commons-codec-1.16.1.pom
            > Could not find org.apache.commons:commons-parent:66.
              Searched in the following locations:
                - file:/home/galasa38/galasaconfig/isolatedrepo/maven/org/apache/commons/commons-parent/66/commons-parent-66.pom
              If the artifact you are trying to retrieve can be found in the repository but without metadata in 'Maven POM' format, you need to adjust the 'metadataSources { ... }' of the repository declaration.
   > Could not find org.apache.httpcomponents:httpcore:4.4.16.
     Searched in the following locations:
       - file:/home/galasa38/galasaconfig/isolatedrepo/maven/org/apache/httpcomponents/httpcore/4.4.16/httpcore-4.4.16.pom
     If the artifact you are trying to retrieve can be found in the repository but without metadata in 'Maven POM' format, you need to adjust the 'metadataSources { ... }' of the repository declaration.
     Required by:
         project : > dev.galasa:dev.galasa.core.manager:0.38.0 > dev.galasa:dev.galasa.platform:0.38.0
         project : > dev.galasa:dev.galasa.http.manager:0.38.0 > dev.galasa:dev.galasa.wrapping.httpclient-osgi:0.38.0
   > Could not find org.apache.httpcomponents:httpmime:4.5.14.
     Searched in the following locations:
       - file:/home/galasa38/galasaconfig/isolatedrepo/maven/org/apache/httpcomponents/httpmime/4.5.14/httpmime-4.5.14.pom
     If the artifact you are trying to retrieve can be found in the repository but without metadata in 'Maven POM' format, you need to adjust the 'metadataSources { ... }' of the repository declaration.
     Required by:
         project : > dev.galasa:dev.galasa.core.manager:0.38.0 > dev.galasa:dev.galasa.platform:0.38.0
         project : > dev.galasa:dev.galasa.http.manager:0.38.0 > dev.galasa:dev.galasa.wrapping.httpclient-osgi:0.38.0

This PR fixes these resolution errors and moves the httpcomponents jars out of the isolated and mvp poms so that they can be embedded along with the other dependency jars in the pom.template files.

The org.apache.httpcomponents.httpclient-osgi bundle was replaced with dev.galasa.wrapping.httpclient-osgi bundle and that doesn't use httpclient-cache or fluent-hc, so these have been removed from the isolated and mvp packaging.

Copy link
Contributor

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@eamansour eamansour merged commit 1761d43 into main Dec 2, 2024
3 checks passed
@eamansour eamansour deleted the em-fix-resolution-errors branch December 2, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants