This repository has been archived by the owner on Nov 11, 2024. It is now read-only.
Separate out loading run artifacts and only load artifacts where needed to improve delete runs performance #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… only where needed Signed-off-by: Eamonn Mansour <[email protected]>
eamansour
force-pushed
the
iss1210-delete-runs-performance
branch
from
5b4ffda to
cb348a8
Compare
techcobweb
reviewed
Sep 12, 2024
...amework.api.ras/src/test/java/dev/galasa/framework/api/ras/internal/mocks/MockRunResult.java
Outdated
Show resolved
Hide resolved
techcobweb
reviewed
Sep 12, 2024
...amework.api.ras/src/test/java/dev/galasa/framework/api/ras/internal/mocks/MockRunResult.java
Outdated
Show resolved
Hide resolved
techcobweb
approved these changes
Sep 12, 2024
Signed-off-by: Eamonn Mansour <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
See galasa-dev/projectmanagement#1210
When getting a run by its ID, all of the artifacts for the given run were being loaded which is unnecessary for API routes that don't care about artifacts. This PR separates the loading of artifacts into a separate
loadArtifactsmethod on the IRunResult interface to provide more flexibility around when to load artifacts for a run.Changes
loadArtifactsmethod to IRunResult interface and added calls to it in the routes that require artifacts to be loaded (i.e. the/ras/runs/{run-id}/artifactsand/ras/runs/{run-id}/files/{artifact-path}routes)