This repository has been archived by the owner on Nov 11, 2024. It is now read-only.
mcobbett refactor events publishing #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Cobbett <[email protected]>
|
Build successful |
jadecarino
reviewed
Aug 27, 2024
galasa-parent/dev.galasa.framework/src/main/java/dev/galasa/framework/BaseTestRunner.java
Outdated
Show resolved
Hide resolved
...ev.galasa.framework/src/main/java/dev/galasa/framework/internal/events/IEventsPublisher.java
Outdated
Show resolved
Hide resolved
...dev.galasa.framework/src/main/java/dev/galasa/framework/internal/events/EventsPublisher.java
Outdated
Show resolved
Hide resolved
...k/src/main/java/dev/galasa/framework/internal/events/FrameworkEventsServiceRegistration.java
Outdated
Show resolved
Hide resolved
...mework/src/main/java/dev/galasa/framework/spi/events/TestRunLifecycleStatusChangedEvent.java
Show resolved
Hide resolved
...arent/dev.galasa.framework/src/test/java/dev/galasa/framework/mocks/MockEventsPublisher.java
Outdated
Show resolved
Hide resolved
|
Build successful |
|
Build successful |
Signed-off-by: Mike Cobbett <[email protected]>
|
Build successful |
jadecarino
approved these changes
Aug 28, 2024
…nerEventProducer... Signed-off-by: Mike Cobbett <[email protected]>
|
Build successful |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why ?
Event producing/publishing within the framework component can be done using a dedicated
interface.
This is part of the general refactoring of the test runners to remove some bad code smells.
In this case, it's having duplicated function, and no class which gathers together all of the usage of the IEventProducer interface.