Skip to content
This repository has been archived by the owner on Nov 11, 2024. It is now read-only.

Add cursor-based pagination to /ras/runs #623

Merged
merged 8 commits into from
Aug 21, 2024

Conversation

eamansour
Copy link
Member

@eamansour eamansour commented Aug 20, 2024

Why?

See galasa-dev/projectmanagement#1921

Changes

  • Added includeCursor query parameter to act as a feature flag enabling cursor-based pagination in /ras/runs
  • Added cursor-based pagination to return an individual page of runs for a given query, which includes a cursor pointing to the next page of runs for the given query to be used in subsequent requests
    • This should improve the current performance of the /ras/runs endpoint as it'll no longer collect all the runs for a query and then discard all but the runs for the requested page
    • The API server now passes the sort query parameter value to CouchDB to sort

@eamansour eamansour changed the title Add cursor-based pagination Add cursor-based pagination to /ras/runs Aug 20, 2024
@eamansour eamansour force-pushed the iss1921-runs-get-performance branch from 42d180f to c7a0035 Compare August 20, 2024 13:09
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-framework-pr-623-r92x7 for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-framework-pr-623-9btzb for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-framework-pr-623-m26v2 for details. If you are unable to do so, please contact a member of the Galasa team.

@eamansour eamansour force-pushed the iss1921-runs-get-performance branch from c7a0035 to c01a265 Compare August 20, 2024 13:48
@galasa-team
Copy link

Build successful

1 similar comment
@galasa-team
Copy link

Build successful

@eamansour eamansour force-pushed the iss1921-runs-get-performance branch from d84712b to 06e211a Compare August 20, 2024 14:09
@galasa-team
Copy link

Build successful

Signed-off-by: Eamonn Mansour <[email protected]>
@eamansour eamansour force-pushed the iss1921-runs-get-performance branch from 271e845 to afbcd59 Compare August 20, 2024 14:21
@galasa-team
Copy link

Build successful

1 similar comment
@galasa-team
Copy link

Build successful

@galasa-team
Copy link

Build successful

@eamansour eamansour requested a review from KirbyKatcher August 20, 2024 15:37
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-framework-pr-623-tpgh5 for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build successful

@eamansour eamansour merged commit 0070969 into main Aug 21, 2024
7 checks passed
@eamansour eamansour deleted the iss1921-runs-get-performance branch August 21, 2024 10:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants