This repository has been archived by the owner on Nov 11, 2024. It is now read-only.
Refactoring of framework test runner so it can have a single unit test running through it all #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t running through it all Signed-off-by: Mike Cobbett <[email protected]>
|
Build successful |
1 similar comment
|
Build successful |
Signed-off-by: Mike Cobbett <[email protected]>
|
Build successful |
Signed-off-by: Mike Cobbett <[email protected]>
|
Build successful |
techcobweb
commented
Aug 19, 2024
galasa-parent/dev.galasa.framework/src/main/java/dev/galasa/framework/BundleManager.java
Outdated
Show resolved
Hide resolved
techcobweb
commented
Aug 19, 2024
galasa-parent/dev.galasa.framework/src/main/java/dev/galasa/framework/BundleManager.java
Outdated
Show resolved
Hide resolved
techcobweb
commented
Aug 19, 2024
galasa-parent/dev.galasa.framework/src/main/java/dev/galasa/framework/IAnnotationExtractor.java
Show resolved
Hide resolved
techcobweb
commented
Aug 19, 2024
...-parent/dev.galasa.framework/src/test/java/dev/galasa/framework/mocks/MockBundleContext.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mike Cobbett <[email protected]>
|
Build successful |
eamansour
approved these changes
Aug 20, 2024
...a-parent/dev.galasa.framework/src/main/java/dev/galasa/framework/spi/IShutableFramework.java
Outdated
Show resolved
Hide resolved
galasa-parent/dev.galasa.framework/src/main/java/dev/galasa/framework/IBundleManager.java
Outdated
Show resolved
Hide resolved
galasa-parent/dev.galasa.framework/src/test/java/dev/galasa/framework/TestTestRunner.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mike Cobbett <[email protected]>
Signed-off-by: Mike Cobbett <[email protected]>
|
Build successful |
Signed-off-by: Mike Cobbett <[email protected]>
|
Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-framework-pr-618-lrrm2 for details. If you are unable to do so, please contact a member of the Galasa team. |
Signed-off-by: Mike Cobbett <[email protected]>
|
Build successful |
|
Build successful |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mike Cobbett [email protected]
Why ?
The java test runner is a huge piece of logic with no unit tests.