unit tests failing due to concurrent access of the mock file system. Make it more reliable #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Make it more reliable Signed-off-by: Mike Cobbett <[email protected]>
eamansour
approved these changes
Dec 18, 2024
|
Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-320-gtgc4-r-6bprl for details. If you are unable to do so, please contact a member of the Galasa team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mike Cobbett [email protected]
Why ?
See issue: Unstable test in CLI causes occasional build failure. MockFS concurrency. #2094
Unit test failed occasionally because of timing/race. 2 threads concurrently accessing/updating the node map inside the mockFileSystem.
Fixed by adding mutexes around all the external calls to the file system, so the internals only run single-threaded. Rather clumsy, but simple and good enough for unit tests.