Merge pull request #156 from galacticcouncil/yield-dca-lifecycle-fix

Fixed lifecycle issues in DCA Yield
galacticcouncil · Dec 4, 2024 · e11afe8 · e11afe8
2 parents 70846e4 + d9f8dac
commit e11afe8
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 7 deletions.
diff --git a/.changeset/moody-suits-count.md b/.changeset/moody-suits-count.md
@@ -0,0 +1,5 @@
+---
+'@galacticcouncil/apps': minor
+---
+
+Fixed lifecycle issues in DCA Yield
diff --git a/packages/apps/src/app/yield/App.ts b/packages/apps/src/app/yield/App.ts
@@ -261,16 +261,21 @@ export class YieldApp extends PoolApp {
     const minInvestment = minGain / (apyMultiplier - 1);
 
     if (minInvestment > Number(amountIn)) {
-      this.dca.error['minInvestmentTooLow'] = i18n.t(
-        'error.minInvestmentTooLow',
-        {
-          amount: humanizeAmount(minInvestment),
-          asset: assetIn.symbol,
+      this.dca = {
+        ...this.dca,
+        error: {
+          ...this.dca.error,
+          minInvestmentTooLow: i18n.t('error.minInvestmentTooLow', {
+            amount: humanizeAmount(minInvestment),
+            asset: assetIn.symbol,
+          }),
         },
-      );
+      };
     } else {
       delete this.dca.error['minInvestmentTooLow'];
     }
+
+    this.requestUpdate();
   }
 
   notificationTemplate(dca: DcaState, tKey: string): TxMessage {
@@ -431,7 +436,10 @@ export class YieldApp extends PoolApp {
   }
 
   protected onIntervalChange({ detail }: CustomEvent) {
-    this.dca.interval = detail.value;
+    this.dca = {
+      ...this.dca,
+      interval: detail.value,
+    };
     this.updateTradeSize();
     this.validateMinInvestment();
   }