-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tokenomics implementation #54
Conversation
Had to skip a few of the check in test_omnipool_amm. I feel like they are not important, but let me know. Also did not get the two-part token-lrna-token swap mechanic to work, and I think it needs more math. But overall I believe everything works that needs to. |
…tive of the agent
I think we also need changes in tests/test_amm.py? At least it appears to be broken for me due to missing 'L'... @jepidoptera |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks right.
…tokenomics_implementation
@jepidoptera in addition to the changes in my comments in my review you will also want to make the fix for the spec issue you noticed in the actual implementation... I only fixed it in the spec. |
actually double-check this... but the implementation already looks correct to me? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good overall, most of these changes are very small.
…tokenomics_implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Updated the implementation to comply with the new spec