Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Image - Repository URL with Port Number #730

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

candidson
Copy link

Description

This solves the following issue #729, allowing to use a format such as "my-custom-repository:5000/myterraform/myimage:latest" as custom terraform image. Additionally, this allows optionally install the curl package on the custom image, making it possible to use root-less customer images (such as in openshift per example).

Checklist for the pull request author

  • Tests added for this feature
  • Commit messages follow conventions (see CONTRIBUTING.md)
  • Commits are combined ( 1 commit / type and scope )
  • Documentation created / updated (if necessary)
  • No new sonarqube issues added
  • CI pipeline is OK
  • Pull request is fast-forward to the main branch
  • The last commit of this merge request :
    • updates the pom.xml to a new minor or major version
    • updates the CHANGELOG.md

Checklist for the project maintainer

  • Review the code, and add a Review Approval if everything is ok
  • This pull request will be merged in merge-commit mode

After the merge

  • Put the tag on the merged commit
  • Follow the pipeline for the tag, which should build & release the package (maven or docker)

Issues / Links

  • Documentation PR : (eg: gaia-app/docs#729)

(Please add issues resolution information when needed)

@candidson
Copy link
Author

Hi @juwit
Anything missing on the PR ? Thanks :-))

@juwit juwit self-assigned this Oct 15, 2022
@juwit juwit added the ✨ feature:modules module list & module edition label Oct 15, 2022
@candidson
Copy link
Author

/push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature:modules module list & module edition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants