Add error handling to WebSocket handleMessage function, resolves #175 #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gagliardetto right now there's no rpc error handling, would be great to have this. As an example, error that I was running into; |
patrulek
reviewed
Dec 5, 2024
| @@ -172,17 +172,37 @@ func (c *Client) handleMessage(message []byte) { | |||
| // when receiving message with id. the result will be a subscription number. | |||
| // that number will be associated to all future message destine to this request | |||
|
|
|||
| // Check for an error in the message. | |||
| if errorCode, errMsg, ok := getJsonRpcError(message); ok { | |||
There was a problem hiding this comment.
https://github.com/gagliardetto/solana-go/blob/main/rpc/jsonrpc/jsonrpc.go#L198
Wouldnt it be possible to reuse RPCResponse here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
getJsonRpcErrorfunction inclient.goto handle errors forhandleMessagec(My IDE automatically fixed that, and undo was difficult).