Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR untuk #27 #33

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

AkipTsaqif
Copy link

Implementasi fitur pencarian bus stop dan juga rute untuk #27

Copy link
Member

@andraantariksa andraantariksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Halo, thank you udah contribute di Open Tije.
Untuk UI behavior search (dan most feature) saat ini kita mau copy aja seperti di BusRouter

PR ini BusRouter

apa bisa diupdate di PR ini? Kalau nggak nanti gw bikin issue baru aja.

@@ -35,6 +77,35 @@ export const MapCanvas: Component = () => {
route.routeToGeoJson(),
),
});

const entry = selectedEntry();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bagian kode ini jalan terus ketika query search berubah. Step to reproduce

  1. Search halte Mega Kuningan
  2. Camera fly to bus stop Mega Kuningan
  3. Gerakin kamera ke GBK
  4. Ketik "Taman"
  5. Camera fly to bus stop Mega Kuningan lagi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants