Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set FGT linkage to PRIVATE #168

Merged
merged 1 commit into from
Apr 23, 2024
Merged

set FGT linkage to PRIVATE #168

merged 1 commit into from
Apr 23, 2024

Conversation

hobu
Copy link
Contributor

@hobu hobu commented Apr 22, 2024

I'm doing some @conda-forge packaging of CPD for PDAL and I'm getting the following error

  The link interface of target "Cpd::Library-C++" contains:

    Fgt::Library-C++

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

Was there any specific reason the FGT linkage is PUBLIC instead of PRIVATE here? If it is PUBLIC for a reason, the Cpd-targets.cmake file is going to need to be updated to do a find_package(Fgt).

Copy link
Owner

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there was a reason, it is lost to the depths of time. Do you need a new release?

@gadomski gadomski merged commit 146d465 into gadomski:main Apr 23, 2024
4 checks passed
@hobu
Copy link
Contributor Author

hobu commented Apr 23, 2024

Do you need a new release?

I'm patching the recipes for now. Once I have them happy I'll ping you to bother with another release.

@hobu hobu deleted the fgt-linkage branch April 23, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants